On April 6, 2025 thus sayeth Daniel Schultz:
> Labels are not allowed before declarations. Add a semicolon after the
> label to introduce an empty statement. This will fix following error:
>
> arch/arm/mach-k3/common_fdt.c: In function 'fdt_fixup_reserved':
> arch/arm/mach-k3/common_fdt.c:156:2: error: a label can only be part of a
> statement and a declaration is not a statement
> 156 | struct fdt_memory carveout = {
> | ^~~~~~
> make[1]: *** [scripts/Makefile.build:256: arch/arm/mach-k3/common_fdt.o]
> Error 1
> make: *** [Makefile:1919: arch/arm/mach-k3] Error 2
>
> Fixes: 096aa229a9e ("mach-k3: common_fdt: create a reserved memory node")
>
> Signed-off-by: Daniel Schultz <d.schu...@phytec.de>
> ---
>
> I'm open to other suggestions! This is just the easiest way to fix this
> compile error. BTW, master is fine since 096aa229a9e is only on next.
>
Ha I learn something new every day. It makes sense as we can't declare
variables inside switch statements so the same rules should apply when
adding jump labels at the function scope.
I was never really in love with the layout of this function, my thought
was to move that carveout structure to the top with all the other
declarations but I'm not apposed to the null statement here either.
Thanks for fixing this
~Bryan
