On 4/7/25 16:17, Jorge Ramirez wrote:
On 07/04/25 14:36:51, neil.armstr...@linaro.org wrote:
On 07/04/2025 14:05, Jorge Ramirez-Ortiz wrote:
Select the right clock for sdhci.

Signed-off-by: Jorge Ramirez-Ortiz <jorge.rami...@oss.qualcomm.com>
Reviewed-by: Neil Armstrong <neil.armstr...@linaro.org>
---
   drivers/clk/qcom/clock-apq8096.c | 2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/qcom/clock-apq8096.c b/drivers/clk/qcom/clock-apq8096.c
index bc00826a5e8..551f52d5197 100644
--- a/drivers/clk/qcom/clock-apq8096.c
+++ b/drivers/clk/qcom/clock-apq8096.c
@@ -83,7 +83,7 @@ static ulong apq8096_clk_set_rate(struct clk *clk, ulong rate)
        struct msm_clk_priv *priv = dev_get_priv(clk->dev);
        switch (clk->id) {
-       case GCC_SDCC1_APPS_CLK: /* SDC1 */
+       case GCC_SDCC2_APPS_CLK: /* SDC2 */

Should be GCC_SDCC2_AHB_CLK

why? also if I do that, mcc fails to probe

GCC_SDCC2_APPS_CLK is correct, that's the "core" clock and the one the sdhci_msm driver calls clk_set_rate() on. So this patch is good. I suspect the misuse of GCC_SDCC1_APPS_CLK is from way back when this board had a custom DT that didn't follow upstream.

Reviewed-by: Caleb Connolly <caleb.conno...@linaro.org>>

                return clk_init_sdc(priv, rate);
                break;
        case GCC_BLSP2_UART2_APPS_CLK: /*UART2*/


--
Caleb (they/them)

Reply via email to