Hi Caleb,
On Thu, 27 Mar 2025 at 10:29, Caleb Connolly <caleb.conno...@linaro.org> wrote:
>
>
>
> On 2/15/25 04:22, Simon Glass wrote:
> > The previous bootloader has already set up the cache, so don't try to do
> > it again.
> >
> > This fixes a crash in QEMU when booting from EDK2
> >
> > Signed-off-by: Simon Glass <s...@chromium.org>
> > ---
> >
> > (no changes since v1)
> >
> > common/board_r.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/common/board_r.c b/common/board_r.c
> > index 81715397544..e7d9a3b312d 100644
> > --- a/common/board_r.c
> > +++ b/common/board_r.c
> > @@ -110,8 +110,9 @@ static int initr_reloc(void)
> > */
> > static int initr_caches(void)
> > {
> > - /* Enable caches */
> > - enable_caches();
> > + if (ll_boot_init())
> > + enable_caches();
>
> For the sake of consistency I think this check should be inverted.
Do you mean:
if (!ll_boot_init())
enable_caches()
But then we wouldn't enable the cache.
> > +
> > return 0;
> > }
> > #endif
>
> --
> Caleb (they/them)
>
Regards,
Simon
