[...]
> > >
> > > - /* Look for device tree that is already installed */
> > > - if (efi_get_configuration_table(&efi_guid_fdt))
> > > - return EFI_SUCCESS;
> >
> > This is the last nit I have an I think these are ready for -next.
> >
> > Instead of removing the existing table in copy_fdt, can we remove it
> > before calling copy_fdt() in efi_install_fdt()
>
> I had actually thought about this, but did not put it in the
> efi_install_fdt() as we have a case for GENERATE_ACPI_TABLE, where we
> are not actually doing anything with the device-tree. So copy_fdt() is
> the place where we know that we are going to install the DT as
> configuration table, so then remove the existing configuration table.
>
Fair enough, leave it as is. I'll queue the patches shortly
Thanks
/Ilias
> >
> > if (efi_get_configuration_table(&efi_guid_fdt))
> > efi_install_configuration_table(&efi_guid_fdt, NULL);
> > should be enough and you can also check the return code that way
>
> For the above scenario, we will not be getting any other error than
> EFI_NOT_FOUND no?
The config table is there it will remove successfully no
If you have a strong opinion on this, I can make the
> change. Please let me know. Thanks.
>
> -sughosh
>
> >
> > Cheers
> > /Ilias
> >
> >
> > > /* Check if there is a hardware device tree */
> > > fdt_opt = env_get("fdt_addr");
> > > /* Use our own device tree as fallback */
> > > --
> > > 2.34.1
> > >
