Hi Tom, On Mon, 17 Mar 2025 at 15:32, Tom Rini <tr...@konsulko.com> wrote: > > On Sat, Mar 15, 2025 at 02:25:27PM +0000, Simon Glass wrote: > > > This is not needed in SPL, so drop it. > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > --- > > > > (no changes since v1) > > > > arch/x86/lib/Makefile | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/x86/lib/Makefile b/arch/x86/lib/Makefile > > index 43e6a1de77d..a908356e8a6 100644 > > --- a/arch/x86/lib/Makefile > > +++ b/arch/x86/lib/Makefile > > @@ -26,7 +26,9 @@ obj-y += e820.o > > obj-y += init_helpers.o > > obj-y += interrupts.o > > obj-y += lpc-uclass.o > > +ifndef CONFIG_XPL_BUILD > > obj-y += mpspec.o > > +endif > > obj-$(CONFIG_$(PHASE_)ACPIGEN) += acpi_nhlt.o > > obj-y += northbridge-uclass.o > > obj-$(CONFIG_I8259_PIC) += i8259.o > > What's going on? This should be discarded if unused in SPL > automatically.
Yes and I'm actually not sure about this. It probably relates to the trouble I had getting BIOS ROMs going in SPL, but since I gave up on that, this patch doesn't seem to be needed. Regards, Simon
