Re: [PATCH 2/3] clk/qcom: sc7280: add some debug data

[Neil Armstrong]

On 14/03/2025 16:31, Caleb Connolly wrote:

Dump a few PCIe and USB clocks

Signed-off-by: Caleb Connolly <caleb.conno...@linaro.org>
---
  drivers/clk/qcom/clock-sc7280.c | 16 ++++++++++++++++
  1 file changed, 16 insertions(+)

diff --git a/drivers/clk/qcom/clock-sc7280.c b/drivers/clk/qcom/clock-sc7280.c
index 
8ffd1f43f23e51140c7822f0f523fdfd8ab1de7a..2cbc01b6e0a4f1db0e4a894cd869b532d6b3fa45
 100644
--- a/drivers/clk/qcom/clock-sc7280.c
+++ b/drivers/clk/qcom/clock-sc7280.c
@@ -99,8 +99,20 @@ static const struct qcom_power_map sc7280_gdscs[] = {
        [GCC_UFS_PHY_GDSC] = { 0x77004 },
        [GCC_USB30_PRIM_GDSC] = { 0xf004 },
  };

+static const phys_addr_t sc7280_rcg_addrs[] = {

+       0x10f020, // USB30_PRIM_MASTER_CLK_CMD_RCGR
+       0x10f038, // USB30_PRIM_MOCK_UTMI_CLK_CMD_RCGR
+       0x18d058, // PCIE_1_AUX_CLK_CMD_RCGR
+};
+
+static const char *const sc7280_rcg_names[] = {
+       "USB30_PRIM_MASTER_CLK_SRC",
+       "USB30_PRIM_MOCK_UTMI_CLK_SRC",
+       "GCC_PCIE_1_AUX_CLK_SRC",
+};
+
  static struct msm_clk_data qcs404_gcc_data = {
        .resets = sc7280_gcc_resets,
        .num_resets = ARRAY_SIZE(sc7280_gcc_resets),
        .clks = sc7280_clks,
@@ -110,8 +122,12 @@ static struct msm_clk_data qcs404_gcc_data = {
        .num_power_domains = ARRAY_SIZE(sc7280_gdscs),

.enable = sc7280_enable,

        .set_rate = sc7280_set_rate,
+
+       .dbg_rcg_addrs = sc7280_rcg_addrs,
+       .num_rcgs = ARRAY_SIZE(sc7280_rcg_addrs),
+       .dbg_rcg_names = sc7280_rcg_names,
  };

static const struct udevice_id gcc_sc7280_of_match[] = {

        {

Reviewed-by: Neil Armstrong <neil.armstr...@linaro.org>