On Tue, Mar 11, 2025 at 9:31 PM Adam Ford <aford...@gmail.com> wrote:
> --- > V2: Fix name of "ECSPI" and elimiate helper function, and fix build error. Still get errors in CI: https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/1057306 Please make sure v3 passes CI. +In file included from board/liebherr/display5/display5.c:30: 3873+include/dm/platform_data/serial_mxc.h:12:25: error: field 'clks' has incomplete type 3874+ 12 | struct clk_bulk clks; 3875+ | ^~~~ 3876+make[2]: *** [scripts/Makefile.build:257: board/liebherr/display5/display5.o] Error 1 3877+make[1]: *** [Makefile:1917: board/liebherr/display5] Error 2 3878+make: *** [Makefile:177: sub-make] Error 2 3879 arm: + kp_imx6q_tpc 3880+drivers/clk/imx/clk-imx6q.c: In function 'imx6q_clk_probe': 3881+drivers/clk/imx/clk-imx6q.c:83:51: error: expected ')' before '{' token 3882+ 83 | if (of_machine_is_compatible("fsl,imx6qp") { 3883+ | ~ ^~ 3884+ | ) 3885+drivers/clk/imx/clk-imx6q.c:83:9: note: '-Wmisleading-indentation' is disabled from this point onwards, since column-tracking was disabled due to the size of the code/headers 3886+ | ^~ 3887+drivers/clk/imx/clk-imx6q.c:83:9: note: adding '-flarge-source-files' will allow for more column-tracking support, at the expense of compilation time and memory 3888+drivers/clk/imx/clk-imx6q.c:179:1: error: expected declaration or statement at end of input 3889+ 179 | }; 3890+ | ^ 3891+drivers/clk/imx/clk-imx6q.c: At top level: 3892+drivers/clk/imx/clk-imx6q.c:41:12: error: 'imx6q_clk_probe' defined but not used [-Werror=unused-function] 3893+ 41 | static int imx6q_clk_probe(struct udevice *dev) 3894+ | ^~~~~~~~~~~~~~~ 3895+drivers/clk/imx/clk-imx6q.c:39:26: error: 'ecspi_sels' defined but not used [-Werror=unused-const-variable=] 3896+ 39 | static const char *const ecspi_sels[] = { "pll3_60m", "osc", }; 3897+ | ^~~~~~~~~~ 3898+drivers/clk/imx/clk-imx6q.c:38:26: error: 'uart_sels' defined but not used [-Werror=unused-const-variable=] 3899+ 38 | static const char *const uart_sels[] = { "pll3_80m", "osc", }; 3900+ | ^~~~~~~~~ 3901+drivers/clk/imx/clk-imx6q.c:36:26: error: 'periph_pre_sels' defined but not used [-Werror=unused-const-variable=] 3902+ 36 | static const char *const periph_pre_sels[] = { "pll2_bus", "pll2_pfd2_396m", 3903+ | ^~~~~~~~~~~~~~~ 3904+drivers/clk/imx/clk-imx6q.c:35:26: error: 'periph_sels' defined but not used [-Werror=unused-const-variable=] 3905+ 35 | static const char *const periph_sels[] = { "periph_pre", "periph_clk2", }; 3906+ | ^~~~~~~~~~~ 3907+drivers/clk/imx/clk-imx6q.c:26:23: error: 'imx6q_clk_ops' defined but not used [-Werror=unused-variable] 3908+ 26 | static struct clk_ops imx6q_clk_ops = { 3909+ | ^~~~~~~~~~~~~ 3910+cc1: all warnings being treated as errors 3911+make[4]: *** [scripts/Makefile.build:257: drivers/clk/imx/clk-imx6q.o] Error 1 3912+make[3]: *** [scripts/Makefile.build:398: drivers/clk/imx] Error 2 3913+make[2]: *** [scripts/Makefile.build:398: drivers/clk] Error 2 3914+make[1]: *** [Makefile:1917: drivers] Error 2 3915+make: *** [Makefile:177: sub-make] Error 2
