On Sat, Mar 08, 2025 at 09:12:11PM +0100, Marek Vasut wrote:

> Add U-Boot adjustments to the libexfat code and integrate
> the result into U-Boot filesystem layer. This provides full
> read-write exfat support for U-Boot available via generic
> filesystem interface.
[snip]
> diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig
> new file mode 100644
> index 00000000000..9f2703a01ee
> --- /dev/null
> +++ b/fs/exfat/Kconfig
> @@ -0,0 +1,4 @@
> +config FS_EXFAT
> +     bool "Enable EXFAT filesystem support"
> +     help
> +       This provides read/write support for EXFAT filesystem.

Since it looks like you're intentionally not adding exfat-prefixed
commands and only using the generic_fs commands, this needs to imply
CMD_FS_GENERIC if CMDLINE so that it can be used.

> diff --git a/fs/exfat/Makefile b/fs/exfat/Makefile
> new file mode 100644
> index 00000000000..824237b6c26
> --- /dev/null
> +++ b/fs/exfat/Makefile
> @@ -0,0 +1,13 @@
> +# SPDX-License-Identifier: GPL-2.0+
> +#
> +
> +obj-$(CONFIG_FS_EXFAT) = \

Filesystems are where we have all of the anti-patterns of "obj-... ="
rather than "+=". It's not a you-must change, but it'd be good to be
consistent with most of the tree.

The rest seems fine, thanks.

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to