Re: [PATCH v2 2/3] ARM: dts: stm32: drop "st,led1" compatible

[Patrice CHOTARD]

On 2/25/25 10:53, Patrice CHOTARD wrote:
> 
> 
> On 2/24/25 19:39, Dario Binacchi wrote:
>> It is pointless to use the custom compatible "st,led1" when
>> stm32746g-eval.dts and stm32f769-disco.dts already contain the
>> "gpio-leds" compatible, which is specifically used for GPIO LEDs
>> management.
>>
>> Signed-off-by: Dario Binacchi <dario.binac...@amarulasolutions.com>
>>
>> ---
>>
>> Changes in v2:
>> - Drop leds node from stm32f746-disco-u-boot.dtsi
>>
>>  arch/arm/dts/stm32746g-eval-u-boot.dtsi    |  5 -----
>>  arch/arm/dts/stm32f746-disco-u-boot.dtsi   |  5 -----
>>  arch/arm/dts/stm32f769-disco-u-boot.dtsi   |  5 -----
>>  board/st/stm32f746-disco/stm32f746-disco.c | 16 ----------------
>>  4 files changed, 31 deletions(-)
>>
>> diff --git a/arch/arm/dts/stm32746g-eval-u-boot.dtsi 
>> b/arch/arm/dts/stm32746g-eval-u-boot.dtsi
>> index f64329287357..32b5c7cea4b8 100644
>> --- a/arch/arm/dts/stm32746g-eval-u-boot.dtsi
>> +++ b/arch/arm/dts/stm32746g-eval-u-boot.dtsi
>> @@ -22,11 +22,6 @@
>>              mmc0 = &sdio1;
>>              spi0 = &qspi;
>>      };
>> -
>> -    led1 {
>> -            compatible = "st,led1";
>> -            led-gpio = <&gpiof 10 0>;
>> -    };
>>  };
>>  
>>  &fmc {
>> diff --git a/arch/arm/dts/stm32f746-disco-u-boot.dtsi 
>> b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
>> index a79fca261a2c..38d797e49a0a 100644
>> --- a/arch/arm/dts/stm32f746-disco-u-boot.dtsi
>> +++ b/arch/arm/dts/stm32f746-disco-u-boot.dtsi
>> @@ -22,11 +22,6 @@
>>              mmc0 = &sdio1;
>>              spi0 = &qspi;
>>      };
>> -
>> -    led1 {
>> -            compatible = "st,led1";
>> -            led-gpio = <&gpioi 1 0>;
>> -    };
>>  };
>>  
>>  &ltdc {
>> diff --git a/arch/arm/dts/stm32f769-disco-u-boot.dtsi 
>> b/arch/arm/dts/stm32f769-disco-u-boot.dtsi
>> index a50fba64dcd2..7c99a6e61b68 100644
>> --- a/arch/arm/dts/stm32f769-disco-u-boot.dtsi
>> +++ b/arch/arm/dts/stm32f769-disco-u-boot.dtsi
>> @@ -23,11 +23,6 @@
>>              spi0 = &qspi;
>>      };
>>  
>> -    led1 {
>> -            compatible = "st,led1";
>> -            led-gpio = <&gpioj 5 0>;
>> -    };
>> -
>>      panel: panel {
>>              compatible = "orisetech,otm8009a";
>>              reset-gpios = <&gpioj 15 1>;
>> diff --git a/board/st/stm32f746-disco/stm32f746-disco.c 
>> b/board/st/stm32f746-disco/stm32f746-disco.c
>> index 65a39d965c72..72f479cea66f 100644
>> --- a/board/st/stm32f746-disco/stm32f746-disco.c
>> +++ b/board/st/stm32f746-disco/stm32f746-disco.c
>> @@ -78,22 +78,6 @@ u32 spl_boot_device(void)
>>  
>>  int board_late_init(void)
>>  {
>> -    struct gpio_desc gpio = {};
>> -    int node;
>> -
>> -    node = fdt_node_offset_by_compatible(gd->fdt_blob, 0, "st,led1");
>> -    if (node < 0)
>> -            return -1;
>> -
>> -    gpio_request_by_name_nodev(offset_to_ofnode(node), "led-gpio", 0, &gpio,
>> -                               GPIOD_IS_OUT);
>> -
>> -    if (dm_gpio_is_valid(&gpio)) {
>> -            dm_gpio_set_value(&gpio, 0);
>> -            mdelay(10);
>> -            dm_gpio_set_value(&gpio, 1);
>> -    }
>> -
>>      return 0;
>>  }
>>  
> 
> Reviewed-by: Patrice Chotard <patrice.chot...@foss.st.com>
> 
> Thanks
> Patrice
Applied to u-boot-stm32/next

Thanks
Patrice