ср, 5 бер. 2025 р. о 16:35 Svyatoslav Ryhel <clamo...@gmail.com> пише: > > ср, 5 бер. 2025 р. о 16:02 Thierry Reding <tred...@nvidia.com> пише: > > > > On Wed, Mar 05, 2025 at 03:52:36PM +0200, Svyatoslav Ryhel wrote: > > > ср, 5 бер. 2025 р. о 15:47 Thierry Reding <tred...@nvidia.com> пише: > > > > > > > > On Wed, Mar 05, 2025 at 01:12:12PM +0200, Svyatoslav Ryhel wrote: > > > > > From: Jonas Schwöbel <jonasschwoe...@yahoo.de> > > > > > > > > > > While PLLD/D2 is the nominal parent clock, all derived clocks are > > > > > generated > > > > > from its single output, plld_out0, which is PLLD/D2 divided by two. > > > > > Direct > > > > > use of PLLD/D2 is absent in peripheral clock configurations. > > > > > Therefore, > > > > > clock derivation formulas must take in account this division. > > > > > > > > > > Signed-off-by: Jonas Schwöbel <jonasschwoe...@yahoo.de> > > > > > Signed-off-by: Svyatoslav Ryhel <clamo...@gmail.com> > > > > > --- > > > > > arch/arm/mach-tegra/clock.c | 30 +++++++++++++++++++++++++++++- > > > > > 1 file changed, 29 insertions(+), 1 deletion(-) > > > > > > > > In Linux we ended up exposing the _out0 branches of the display clocks. > > > > Wouldn't that be a better way to describe this? > > > > > > > > Thierry > > > > > > You are not satisfied with the description or with solution? > > > > I meant the solution. However I might have misunderstood what you're > > doing here. This is actually computing the rate of the _out0 branches, > > which are the ones listed in the DTS files as parents, correct? > > > > Basically this is u-boot equivalent of Linux approach, well its final > stage. This patch does 2 things. First, it updates pll_rate[id] value > if rate is changed which was not done since usually PLL do not need > updates till we hit display clocks. Second, it fixes display clock > children divider calculation taking in account that raw plld/d2 freq > is halved. And all this does not break existing drivers which use plld > in any way (I have checked that on all generations till t124 > including). > > Introducing plld_out0 instead of plld Tegra wide will basically add > more confusion and possibly hidden regressions since all drivers using > plld as parent take in account this quirk. >
If you have no suggestions, objections or proposals, I assume this patch can be accepted. > > Thierry
