On Sun, 9 Mar 2025 at 14:29, Ilias Apalodimas
<ilias.apalodi...@linaro.org> wrote:
>
> HI Sughosh,
>
> [.,.]
>
> > +static int pmem_node_efi_memmap_setup(void *fdt, ulong addr, u32 size)
> > +{
> > + int ret;
> > + efi_status_t status;
> > +
> > + ret = fdt_fixup_pmem_region(fdt, addr, size);
>
> As we discussed offline, this will never get called if bootefi has run
> before the final OS image we want to load.
Yes, we currently have the logic where if a DT is installed on the
configuration table, the DT does not get installed afresh. Only thing
I was wondering was if this logic was put in place for some specific
use-case. We are now going to change the logic completely so it should
not be that it breaks some current assumption made in the code
somewhere. But then like Heinrich mentioned in the other thread, this
change was made in 6182495e101 ("efi_loader: need either ACPI table or
device tree"), which was authored by him. So if he is suggesting that
we install a DT afresh, it should be fine.
I already have the patches ready. Will post them once I have done the
required testing. Thanks.
-sughosh
> The reason is that U-Boot checks the installed config table and skips
> the installation. Earlier versions where applying the fixup on the
> config table for that reason.
> Since Heinrich and you agreed that the DT can unconditionally be
> re-installed, I think you should send a v7 including that patch.
>
> Cheers
> /Ilias
