On 3/4/25 11:32 AM, Paul Barker wrote:
On 03/03/2025 23:16, Marek Vasut wrote:
On 3/3/25 8:29 PM, Paul Barker wrote:
On 02/03/2025 01:24, Marek Vasut wrote:
Move miiphybb operations into separate struct bb_miiphy_bus_ops
structure, add pointer to struct bb_miiphy_bus_ops into the base
struct bb_miiphy_bus and access the ops through this pointer in
miiphybb generic code. The variable reshuffling in miiphybb.c
cannot be easily avoided.
Signed-off-by: Marek Vasut <marek.vasut+rene...@mailbox.org>
Hi Marek,
I'm a bit lost trying to review this series. Could you include a cover
letter summarising the change to the bitbangmii API? We also need to
update `doc/README.bitbangMII`.
In short, this splits ops from the bbmiiphy structure, which is entirely
removed in the course of this series, and so are all the bbmiiphy
alloc/free functions again. That in turn fixes the missed mdio_free()
update, which no longer has to be fixed, as the drivers go back to
mdio_alloc() to allocate the MDIO bus.
Ok, I've given this another look and it all looks ok. I'll send tags
shortly.
I do think we should update the documentation to match the new API.
Documentation update is now posted at:
[PATCH] net: miiphybb: Update documentation
Thanks !
