On 3/3/25 10:44 AM, Quentin Schulz wrote:
Hi Marek,

Hi,

[...]

  board/renesas/common/gen4-common.c | 126 +++++++++++++++++++++++++++++
  1 file changed, 126 insertions(+)

diff --git a/board/renesas/common/gen4-common.c b/board/renesas/ common/gen4-common.c
index 52a0639073b..f7d129be4c8 100644
--- a/board/renesas/common/gen4-common.c
+++ b/board/renesas/common/gen4-common.c

I'm wondering if it really makes sense to have this in board/? If I understood correctly, this is all SoC-specific? So shouldn't that rather be in arch/arm/mach-renesas maybe? So that boards based on an R-Car gen4 SoC don't have to set SYS_VENDOR to renesas or copy the code in their own board/<vendor>/common directory?

What do you think?

Once it gets thoroughly tested on the other SoCs, then it can be moved into more generic location, sure.

--
Best regards,
Marek Vasut

Reply via email to