On Fri, 28 Feb 2025 at 13:46, Alexander Dahl <a...@thorsis.com> wrote: > > Hei hei, > > Am Thu, Feb 27, 2025 at 03:05:52PM +0530 schrieb Manikandan Muralidharan: > > Add PMC clock definitions for MCK and UTMI which will be required > > for the sam9x7 OF_upstream DT since the clock framework is not in > > sync with Linux and also include this header in 'clock/at91.h' file > > > > Signed-off-by: Manikandan Muralidharan <manikanda...@microchip.com> > > --- > > include/dt-bindings/clk/at91.h | 3 +++ > > include/dt-bindings/clock/at91.h | 2 ++ > > 2 files changed, 5 insertions(+) > > > > diff --git a/include/dt-bindings/clk/at91.h b/include/dt-bindings/clk/at91.h > > index a178b94157b..016c6e0c620 100644 > > --- a/include/dt-bindings/clk/at91.h > > +++ b/include/dt-bindings/clk/at91.h > > @@ -24,4 +24,7 @@ > > #define USB_UTMI2 1 > > #define USB_UTMI3 2 > > > > +#define PMC_MCK 1 > > +#define PMC_UTMI 2 > > These are in include/dt-bindings/clock/at91.h in Linux. > > > + > > #endif > > diff --git a/include/dt-bindings/clock/at91.h > > b/include/dt-bindings/clock/at91.h > > index ab3ee241d10..7235b3ba01e 100644 > > --- a/include/dt-bindings/clock/at91.h > > +++ b/include/dt-bindings/clock/at91.h > > @@ -6,6 +6,8 @@ > > * Licensed under GPLv2 or later. > > */ > > > > +#include <dt-bindings/clk/at91.h> > > If the u-boot driver or some *-u-boot.dtsi needs that additional > header, I would include it there. > > Besides this, you might be interested those bindings are in a process > of rework in Linux currently. Especially the PMC clock IDs you ported > from Linux are about to be split out into SoC specific headers. > Discussion over here: > > https://lore.kernel.org/linux-clk/20250210164506.495747-2-...@thorsis.com/
AFAICS, currently you are just creating duplicate SoC headers. I suppose you don't plan to drop bits from include/dt-bindings/clock/at91.h since that will be a backwards incompatible change and will break U-Boot drivers since they will rely on it. -Sumit > > Greets > Alex > > > > + > > #ifndef _DT_BINDINGS_CLK_AT91_H > > #define _DT_BINDINGS_CLK_AT91_H > > > > -- > > 2.25.1 > >
