Hi Tom,
On Thu, 27 Feb 2025 at 09:26, Tom Rini <tr...@konsulko.com> wrote:
>
> On Thu, Feb 27, 2025 at 09:17:15AM -0700, Simon Glass wrote:
> > Hi Tom,
> >
> > On Wed, 26 Feb 2025 at 14:13, Tom Rini <tr...@konsulko.com> wrote:
> > >
> > > On Wed, Feb 26, 2025 at 09:26:15AM -0700, Simon Glass wrote:
> > >
> > > > Snow requires a fixed bloblist to operate, so re-enable this option.
> > > >
> > > > Signed-off-by: Simon Glass <s...@chromium.org>
> > > > Fixes: 864106f3c47 ("bloblist: Make BLOBLIST_ALLOC the default")
> > > > ---
> > > >
> > > > (no changes since v1)
> > > >
> > > > configs/snow_defconfig | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/configs/snow_defconfig b/configs/snow_defconfig
> > > > index 7a1dc80b1cc..f9fd76daa67 100644
> > > > --- a/configs/snow_defconfig
> > > > +++ b/configs/snow_defconfig
> > > > @@ -33,7 +33,9 @@ CONFIG_DISTRO_DEFAULTS=y
> > > > CONFIG_SYS_PBSIZE=1024
> > > > CONFIG_SILENT_CONSOLE=y
> > > > CONFIG_BLOBLIST=y
> > > > +CONFIG_BLOBLIST_FIXED=y
> > > > # CONFIG_SPL_BLOBLIST is not set
> > > > +CONFIG_BLOBLIST_ADDR=0x43d00000
> > > > # CONFIG_SPL_FRAMEWORK is not set
> > > > CONFIG_SPL_FOOTPRINT_LIMIT=y
> > > > CONFIG_SPL_MAX_FOOTPRINT=0x3800
> > >
> > > I'm not going to NAK the patch, but:
> > > - "snow" does not require a bloblist to operate, just to run the
> > > bloblist tests on hardware
> >
> > That's right. 'snow' is the platform I chose to try to run more of the
> > sandbox tests, although I haven't done much with that.
>
> I use a Pi for trying to run more tests on and yes, good to know.
>
> > > as implied by d985f1dbddb2 ("bootstd: Add a
> > > test for the bootstd menu"), which also don't seem to run anyhow?
> >
> > The bootstd tests all need sandbox at present, since there are images
> > required. If you were interested in my idea of building the
> > 'image-setup' stuff into the pytests, then we could change that.
>
> I just mean it wasn't clear that test/common/bloblist.c was run when
> BLOOBLIST is enabled on snow. But I didn't dig too hard and compare the
> output with sandbox when we pass stdout through pytest output too.
Yes, they do seem to run OK...I put part of the output from 'ub-pyt
snow' below[1]
>
> > > - We could just as easily continue to use an allocated bloblist if
> > > CONFIG_SYS_MALLOC_F_LEN is increased to say 0x800 from 0x400 (which is
> > > the same size as the requested bloblist allocation).
> >
> > OK
> >
> > > - This very tiny SYS_MALLOC_F_LEN is just the old default value from
> > > when it was bumped up to 0x2000 for most platforms and is also safe
> > > from a quick test.
> >
> > OK. I didn't get time to look at bloblist last weekend and this one is
> > not looking good either, but I will get to it.
>
> OK.
>
> --
> Tom
Regards,
Simon
[1]
test/py/tests/test_ut.py sssnow # ut bdinfo bdinfo_test_eth
Test: eth: bdinfo.c
Skipping: Console recording disabled
Tests run: 1, 8 ms, average: 8 ms, skipped: 1, failures: 0
snow # .snow # ut bdinfo bdinfo_test_full
Test: full: bdinfo.c
Skipping: Console recording disabled
Tests run: 1, 8 ms, average: 8 ms, skipped: 1, failures: 0
snow # .snow # ut bdinfo bdinfo_test_help
Test: help: bdinfo.c
Skipping: Console recording disabled
Tests run: 1, 8 ms, average: 8 ms, skipped: 1, failures: 0
snow # .snow # ut bdinfo bdinfo_test_memory
Test: memory: bdinfo.c
Skipping: Console recording disabled
Tests run: 1, 8 ms, average: 8 ms, skipped: 1, failures: 0
snow # .snow # ut bloblist bloblist_test_align
Test: align: bloblist.c
Tests run: 1, 3 ms, average: 3 ms, failures: 0
snow # .snow # ut bloblist bloblist_test_bad_blob
Test: bad_blob: bloblist.c
Tests run: 1, 3 ms, average: 3 ms, failures: 0
snow # .snow # ut bloblist bloblist_test_blob
Test: blob: bloblist.c
Tests run: 1, 4 ms, average: 4 ms, failures: 0
snow # .snow # ut bloblist bloblist_test_blob_ensure
Test: blob_ensure: bloblist.c
Failed to allocate 3e0 bytes
Used size=30, total size=400
Tests run: 1, 11 ms, average: 11 ms, failures: 0
snow # .snow # ut bloblist bloblist_test_blob_maxsize
Test: blob_maxsize: bloblist.c
Failed to allocate 3e1 bytes
Used size=400, total size=400
Tests run: 1, 12 ms, average: 12 ms, failures: 0
snow # .snow # ut bloblist bloblist_test_checksum
Test: checksum: bloblist.c
Checksum b3 != b7
Checksum b3 != b5
Checksum b3 != b2
Checksum b4 != b3
Checksum b3 != b2
Checksum b3 != a0
Checksum b3 != 64
Checksum 64 != 63
Checksum 64 != 63
Checksum 64 != 63
Checksum 64 != 63
Tests run: 1, 34 ms, average: 34 ms, failures: 0
snow # .snow # ut bloblist bloblist_test_cmd_info
Test: cmd_info: bloblist.c
Skipping: Console recording disabled
Tests run: 1, 8 ms, average: 8 ms, skipped: 1, failures: 0
snow # .snow # ut bloblist bloblist_test_cmd_list
Test: cmd_list: bloblist.c
Skipping: Console recording disabled
Tests run: 1, 8 ms, average: 8 ms, skipped: 1, failures: 0
snow # .snow # ut bloblist bloblist_test_grow
Test: grow: bloblist.c
Tests run: 1, 4 ms, average: 4 ms, failures: 0
snow # .snow # ut bloblist bloblist_test_init
Test: init: bloblist.c
Checksum 0 != b3
Checksum b3 != b2
Tests run: 1, 8 ms, average: 8 ms, failures: 0
snow # .snow # ut bloblist bloblist_test_reloc
Test: reloc: bloblist.c
Failed to allocate 400 bytes
Used size=40, total size=400
Tests run: 1, 11 ms, average: 11 ms, failures: 0
snow # .snow # ut bloblist bloblist_test_resize_fail
Test: resize_fail: bloblist.c
Failed to allocate 3b9 bytes
Used size=68, total size=400
Tests run: 1, 11 ms, average: 11 ms, failures: 0
snow # .snow # ut bloblist bloblist_test_resize_last
Test: resize_last: bloblist.c
Tests run: 1, 4 ms, average: 4 ms, failures: 0
snow # .snow # ut bloblist bloblist_test_shrink
Test: shrink: bloblist.c
Tests run: 1, 4 ms, average: 4 ms, failures: 0
