Hi Stephen!
On Thu, 20 Feb 2025 at 13:59, Stephen Boyd <swb...@chromium.org> wrote:
>
> This should be negative EFAULT to indicate an error code.
>
> Signed-off-by: Stephen Boyd <swb...@chromium.org>
> ---
> boot/bootmeth_cros.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/boot/bootmeth_cros.c b/boot/bootmeth_cros.c
> index c7b862e512a0..d4c4ed328bd0 100644
> --- a/boot/bootmeth_cros.c
> +++ b/boot/bootmeth_cros.c
> @@ -340,7 +340,7 @@ static int cros_read_kernel(struct bootflow *bflow)
>
> /* Check that the header is not smaller than permitted */
> if (priv->body_offset < PROBE_SIZE)
> - return log_msg_ret("san", EFAULT);
> + return log_msg_ret("san", -EFAULT);
>
> /* Read kernel body */
> num_blks = priv->body_size >> desc->log2blksz;
> --
> Sent by a computer, using git, on the internet
>
Reviewed-by: Simon Glass <s...@chromium.org>
Regards,
Simon
