On Thu, Feb 20, 2025 at 08:44:23PM +0000, Caleb Connolly wrote:

[ . . . ]

> > +&sdhc_1 {
> > +   sdhci-caps-mask = <0x0 0x04000000>;
> > +   sdhci-caps = <0x0 0x04000000>;  /* SDHCI_CAN_VDD_180 */
> > +
> > +   /*
> > +    * This reset is needed to clear out the settings done by
> > +    * previous boot loader. Without this the SDHCI_RESET_ALL
> > +    * reset done sdhci_init() times out.
> > +    */
> > +   resets = <&gcc GCC_SDCC_BCR>;
>
> I understand that Linux doesn't need this reset, but devicetree doesn't
> exist in Linux to describe what Linux drivers need, it exists to describe
> the hardware. This reset should go upstream. Ultimately this file exists
> purely as a stop-gap solution and the goal must be to get rid of it in the
> future.
>
> I'd appreciate it if you could also send a patch to the kernel adding this
> missing reset.

Have the change ready and tested. Will check with the person who
posted initially without reset to confirm that I'm not missing
something and then post it soon.

Thanks
Varada

Reply via email to