> -----Original Message-----
> From: Simon Glass <s...@chromium.org>
> Sent: Tuesday, 18 February 2025 9:29 pm
> To: Maniyam, Dinesh <dinesh.mani...@intel.com>
> Cc: u-boot@lists.denx.de; Marek <ma...@denx.de>; Simon Goldschmidt
> <simon.k.r.goldschm...@gmail.com>; Tom Rini <tr...@konsulko.com>; Ilias
> Apalodimas <ilias.apalodi...@linaro.org>; Heinrich Schuchardt
> <xypron.g...@gmx.de>; Jerome Forissier <jerome.foriss...@linaro.org>; Mattijs
> Korpershoek <mkorpersh...@baylibre.com>; Ibai Erkiaga <ibai.erkiaga-
> elo...@amd.com>; Michal Simek <michal.si...@amd.com>; Dmitry Rokosov
> <ddroko...@salutedevices.com>; Jonas Karlman <jo...@kwiboo.se>; Sebastian
> Reichel <sebastian.reic...@collabora.com>; Wang Jie <dave.wang@rock-
> chips.com>; Meng, Tingting <tingting.m...@intel.com>; Chee, Tien Fong
> <tien.fong.c...@intel.com>; Hea, Kok Kiang <kok.kiang....@intel.com>; Ng,
> Boon Khai <boon.khai...@intel.com>; Yuslaimi, Alif Zakuan
> <alif.zakuan.yusla...@intel.com>; Zamri, Muhammad Hazim Izzat
> <muhammad.hazim.izzat.za...@intel.com>; Lim, Jit Loon
> <jit.loon....@intel.com>; Tang, Sieu Mun <sieu.mun.t...@intel.com>
> Subject: Re: [PATCH 02/10] drivers: i3c: Add new i3c uclass id
>
> Hi Dinesh,
>
> On Mon, 17 Feb 2025 at 19:57, <dinesh.mani...@intel.com> wrote:
> >
> > From: Dinesh Maniyam <dinesh.mani...@intel.com>
> >
> > Add i3c general uclass id.
> >
> > Signed-off-by: Dinesh Maniyam <dinesh.mani...@intel.com>
> > ---
> > include/dm/uclass-id.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/include/dm/uclass-id.h b/include/dm/uclass-id.h index
> > 270088ad94..1d259b439f 100644
> > --- a/include/dm/uclass-id.h
> > +++ b/include/dm/uclass-id.h
> > @@ -78,6 +78,7 @@ enum uclass_id {
> > UCLASS_I2C_GENERIC, /* Generic I2C device */
> > UCLASS_I2C_MUX, /* I2C multiplexer */
> > UCLASS_I2S, /* I2S bus */
> > + UCLASS_I3C, /* I3C bus */
> > UCLASS_IDE, /* IDE device */
> > UCLASS_IOMMU, /* IOMMU */
> > UCLASS_IRQ, /* Interrupt controller */
> > --
> > 2.26.2
> >
>
> When you add a new uclass, please add a sandbox driver and some tests.
> There is the existing i2c to follow, but your tests may be simpler.
>
> Regards,
> Simon
Thanks for the reference, will add the sandbox driver and simple tests in v2.
Regards
Dinesh
