Hi Alice,

On Tue, 18 Feb 2025 at 05:11, Alice Guo (OSS) <alice....@oss.nxp.com> wrote:
>
> From: Alice Guo <alice....@nxp.com>
>
> i.MX95 needs to combine DDR PHY firmware images and their byte counts
> together, so add a new entry type nxp-header-ddrfw for this requirement.
>
> Signed-off-by: Alice Guo <alice....@nxp.com>
> ---
>  tools/binman/entries.rst                  | 10 +++++++
>  tools/binman/etype/nxp_header_ddrfw.py    | 32 +++++++++++++++++++++++
>  tools/binman/ftest.py                     | 11 ++++++++
>  tools/binman/test/346_nxp_ddrfw_imx95.dts | 24 +++++++++++++++++
>  4 files changed, 77 insertions(+)
>  create mode 100644 tools/binman/etype/nxp_header_ddrfw.py
>  create mode 100644 tools/binman/test/346_nxp_ddrfw_imx95.dts

When I run 'binman test -T' I see that there is missing coverage:

tools/binman/etype/nxp_header_ddrfw.py
              14      1    93%
> +    See imx95_evk.rst for how to get DDR PHY Firmware Images.

Your test is a good start. But please add a few more to get this to
100%, or remove some unused code from your etype.

Regards,
Simon

Reply via email to