On Sat, Feb 15, 2025 at 10:21:43AM -0700, Simon Glass wrote:
> Hi Tom,
>
> On Sat, 15 Feb 2025 at 07:49, Tom Rini <tr...@konsulko.com> wrote:
> >
> > On Sat, Feb 15, 2025 at 05:17:48AM -0700, Simon Glass wrote:
> > > Hi Tom,
> > >
> > > On Mon, 10 Feb 2025 at 08:52, Tom Rini <tr...@konsulko.com> wrote:
> > > >
> > > > On Sun, Feb 09, 2025 at 09:07:18AM -0700, Simon Glass wrote:
> > > >
> > > > > It is sometimes tricky to figure out what modules test.py is loading
> > > > > when it starts up. The result can be a silent failure with no clue as
> > > > > to
> > > > > what when wrong.
> > > > >
> > > > > Add a section which lists the modules loaded as well as those not
> > > > > found.
> > > > >
> > > > > Signed-off-by: Simon Glass <s...@chromium.org>
> > > > > ---
> > > > >
> > > > > (no changes since v1)
> > > > >
> > > > > test/py/conftest.py | 33 ++++++++++++++++++++-------------
> > > > > 1 file changed, 20 insertions(+), 13 deletions(-)
> > > > >
> > > > > diff --git a/test/py/conftest.py b/test/py/conftest.py
> > > > > index 8d0e786ee5c..e59897c1f78 100644
> > > > > --- a/test/py/conftest.py
> > > > > +++ b/test/py/conftest.py
> > > > > @@ -289,19 +289,26 @@ def pytest_configure(config):
> > > > > ubconfig = ArbitraryAttributeContainer()
> > > > > ubconfig.brd = dict()
> > > > > ubconfig.env = dict()
> > > > > -
> > > > > - modules = [
> > > > > - (ubconfig.brd, 'u_boot_board_' + board_type_filename),
> > > > > - (ubconfig.env, 'u_boot_boardenv_' + board_type_filename),
> > > > > - (ubconfig.env, 'u_boot_boardenv_' + board_type_filename +
> > > > > '_' +
> > > > > - board_identity_filename),
> > > > > - ]
> > > > > - for (dict_to_fill, module_name) in modules:
> > > > > - try:
> > > > > - module = __import__(module_name)
> > > > > - except ImportError:
> > > > > - continue
> > > > > - dict_to_fill.update(module.__dict__)
> > > > > + not_found = []
> > > > > +
> > > > > + with log.section('Loading lab modules', 'load_modules'):
> > > > > + modules = [
> > > > > + (ubconfig.brd, 'u_boot_board_' + board_type_filename),
> > > > > + (ubconfig.env, 'u_boot_boardenv_' + board_type_filename),
> > > > > + (ubconfig.env, 'u_boot_boardenv_' + board_type_filename
> > > > > + '_' +
> > > > > + board_identity_filename),
> > > > > + ]
> > > > > + for (dict_to_fill, module_name) in modules:
> > > > > + try:
> > > > > + module = __import__(module_name)
> > > > > + except ImportError:
> > > > > + not_found.append(module_name)
> > > > > + continue
> > > > > + dict_to_fill.update(module.__dict__)
> > > > > + log.info(f"Loaded {module}")
> > > > > +
> > > > > + if not_found:
> > > > > + log.warning(f"Failed to find modules: {'
> > > > > '.join(not_found)}")
> > > >
> > > > Since no platform contains all of those files this is too verbose.
> > >
> > > So perhaps only show the message if all files are missing?
> >
> > Sure. Or a log.debug maybe?
>
> The log.debug() doesn't show up though and people wouldn't know where
> to look. So if you are OK with having the message only if there is
> nothing, I will do that.Sure. -- Tom
signature.asc
Description: PGP signature
