Re: [PATCH 2/2] pinctrl: qcom: sm8250: fix pin count

[Neil Armstrong]

On 10/02/2025 17:30, Caleb Connolly wrote:

The pin count wasn't updated when the special pins were added, as a
result it was never possible to configure the special pins on SM8250
boards.

Fix the pin count and allow the special pins to be configured. This
fixes sdcard support on the RB5.

Fixes: 58fa52042471 ("pinctr: qcom: sm8250: add special pins pins configuration 
data")
Signed-off-by: Caleb Connolly <caleb.conno...@linaro.org>
---
  drivers/pinctrl/qcom/pinctrl-sm8250.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-sm8250.c 
b/drivers/pinctrl/qcom/pinctrl-sm8250.c
index 
cab42fa64ed2eeda7259b0f6065bae8779d06d34..b21cdc4d24b7abd34d3a08a5e1f5d74f9bba4184
 100644
--- a/drivers/pinctrl/qcom/pinctrl-sm8250.c
+++ b/drivers/pinctrl/qcom/pinctrl-sm8250.c
@@ -106,9 +106,9 @@ static unsigned int sm8250_get_function_mux(__maybe_unused 
unsigned int pin, uns

static struct msm_pinctrl_data sm8250_data = {

        .pin_data = {
                .pin_offsets = sm8250_pin_offsets,
-               .pin_count = ARRAY_SIZE(sm8250_pin_offsets),
+               .pin_count = 184,
                .special_pins_start = 180,
                .special_pins_data = sm8250_special_pins_data,
        },
        .functions_count = ARRAY_SIZE(msm_pinctrl_functions),

Reviewed-by: Neil Armstrong <neil.armstr...@linaro.org>