On Wed, Feb 05, 2025 at 09:16:46AM +0200, Ilias Apalodimas wrote: > Since we added support in meminfo to dump live page tables, describe > the only working architecture for now (aarch64) and add links to public > documentation for further reading. > > Signed-off-by: Ilias Apalodimas <ilias.apalodi...@linaro.org>
Generally looks good, a small change however please: [snip] > @@ -26,8 +27,9 @@ The layout of memory is set up before relocation, within > the init sequence in > ending with the stack. This results in the maximum possible amount of memory > being left free for image-loading. > > -The meminfo command writes the DRAM size, then the rest of its outputs in 5 > -columns: > +The meminfo command writes the DRAM size. If the architecture supports it > +(currently only aarch64) dumps the page table entries and then the rest of > +its outputs in 5 columns: How about: If the architecture also supports it, page table entries will be shown next. Finally the rest of the outputs are printed in 5 columns: This will make sure that when the next architecture adds support the documentation doesn't need to be updated here (and the temptation to list every arch that does this will be resisted). Thanks! -- Tom
signature.asc
Description: PGP signature