Dear Luca Ceresoli,
In message <1305388203-22983-5-git-send-email-luca.ceres...@comelit.it> you
wrote:
> This removes the following checkpatch issue:
> - ERROR: do not use assignment in if condition.
>
> There is one such error left:
>
> ERROR: do not use assignment in if condition
> #239: FILE: tftp.c:239:
> + if (!ProhibitMcast
> + && (Bitmap = malloc(Mapsize))
> + && eth_get_dev()->mcast) {
>
> which would require an additional nested if to be fixed, resulting in longer
> and less readable code.
>
> Signed-off-by: Luca Ceresoli <luca.ceres...@comelit.it>
> Cc: Wolfgang Denk <w...@denx.de>
> ---
> net/tftp.c | 18 ++++++++++++------
> 1 files changed, 12 insertions(+), 6 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
"It's hard to believe that something which is neither seen nor felt
can do so much harm."
"That's true. But an idea can't be seen or felt. And that's what kept
the Troglytes in the mines all these centuries. A mistaken idea."
-- Vanna and Kirk, "The Cloud Minders", stardate 5819.0
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
