Hi Ilias, On Tue, 14 Jan 2025 at 01:40, Ilias Apalodimas <ilias.apalodi...@linaro.org> wrote: > > Hi Simon, > > On Fri, 10 Jan 2025 at 16:54, Simon Glass <s...@chromium.org> wrote: > > > > Hi again Ilias, > > > > On Thu, 2 Jan 2025 at 18:41, Simon Glass <s...@chromium.org> wrote: > > > > > > Hi Ilias, > > > > > > On Fri, 3 Jan 2025 at 08:15, Ilias Apalodimas > > > <ilias.apalodi...@linaro.org> wrote: > > > > > > > > > > > > Apologies for the formatting, replying on mobile. > > > > > > > > On Wed, Jan 1, 2025, 21:58 Simon Glass <s...@chromium.org> wrote: > > > >> > > > >> Linaro has decided to write their own version of bloblist from scratch, > > > >> so there is no point in having a non-GPL license on this file. Change > > > >> it, to better fit with the U-Boot project. > > > > > > > > > > > > Apart from the commit message being wrong, it's also intentionally > > > > provoking. There was no bloblist in TF-A. > > > > > > > > The TF-A code is implementing the firmware hand-off spec [0], which > > > > Linaro participated in the creation. The U-Boot implementation was > > > > adjusted to adhere to the same spec after the TF-A code was merged. > > > > > > The U-Boot series was [1], for reference. This was mostly about using > > > different tags and shrinking the headers. My clear understanding was > > > that we were going to try to have a single codebase, which is why I > > > changed the license. > > > > > > So, since you have a different view of events, why did Linaro write it > > > from scratch? Was it to avoid having U-Boot code in TF-A? Or was the > > > author just unaware of the original intention? > > I am not sure I am following 'from scratch'. Firmware handoff is a doc > describing a list. Raymond implemented it in U-Boot and TF-A.
So in your mind, Raymond implemented it in U-Boot? Have you taken a look at 'git log' or 'git blame'? > The right way to do this is to move the firmware handoff code to a > library that can be used across projects. Not always. Probably not in this case. It has quite a bit of logic which depends on its environment. So I think it is better to have 'similar' code in several projects. Certainly, writing it from scratch (meaning not based on existing code) is not the best approach. > > > It isn't relevant for > > > the commit message, but if you can find out I would be interested. > > > > Just following up on this as I'm not sure of the status of this patch. > > Can you perhaps write your own commit message with your version of > > what Linaro has done? > > "The non-GPL license was inadvertently added, remove it". Raymond > wrote that code so I don't think he minds removing the extra license. Again, please check your assertion here. I for one am very surprised to hear that Raymond wrote the bloblist code :-) But it does help to explain why you objected to my commit message. Regards, Simon
