From: Ilias Apalodimas <ilias.apalodi...@linaro.org>
When that function was introduced we were only using it to check if
extending a PCR was allowed, so the name made sense. A few patches ago
we used that function to reason about the EventLog creation and general
usage of PCRs , so let's rename it to something more generic that makes
more sense in all contexts.
Signed-off-by: Ilias Apalodimas <ilias.apalodi...@linaro.org>
Signed-off-by: Raymond Mao <raymond....@linaro.org>
---
Changes in v2
- None.
include/tpm-v2.h | 5 +++--
lib/tpm-v2.c | 4 ++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/include/tpm-v2.h b/include/tpm-v2.h
index 8c43f4fd9b..87b2c614ad 100644
--- a/include/tpm-v2.h
+++ b/include/tpm-v2.h
@@ -732,12 +732,13 @@ u16 tpm2_algorithm_to_len(enum tpm2_algorithms algo);
*/
/**
- * tpm2_allow_extend() - Check if extending PCRs is allowed and safe
+ * tpm2_check_active_banks() - Check if the active PCR banks are supported by
+ * our configuration
*
* @dev: TPM device
* Return: true if allowed
*/
-bool tpm2_allow_extend(struct udevice *dev);
+bool tpm2_check_active_banks(struct udevice *dev);
/**
* tpm2_is_active_bank() - check the pcr_select. If at least one of the PCRs
diff --git a/lib/tpm-v2.c b/lib/tpm-v2.c
index cb636414de..0edb0aa90c 100644
--- a/lib/tpm-v2.c
+++ b/lib/tpm-v2.c
@@ -197,7 +197,7 @@ u32 tpm2_pcr_extend(struct udevice *dev, u32 index, u32
algorithm,
if (!digest)
return -EINVAL;
- if (!tpm2_allow_extend(dev)) {
+ if (!tpm2_check_active_banks(dev)) {
log_err("Cannot extend PCRs if all the TPM enabled algorithms
are not supported\n");
return -EINVAL;
}
@@ -896,7 +896,7 @@ u16 tpm2_algorithm_to_len(enum tpm2_algorithms algo)
return 0;
}
-bool tpm2_allow_extend(struct udevice *dev)
+bool tpm2_check_active_banks(struct udevice *dev)
{
struct tpml_pcr_selection pcrs;
size_t i;
--
2.25.1
