On Thu, Dec 19, 2024 at 09:01:19PM -0700, Simon Glass wrote:

> The current localboot implementation assumes that a 'localcmd'
> environment variable is provided, with the instructions to follow. This
> may not be included, so provide a fallback in that case.
> 
> Add a test image and test as well.
> 
> Signed-off-by: Simon Glass <s...@chromium.org>

This is a pretty niche feature, I had to dig around a bit to see how
it's specified elsewhere (not really) and how it's used. And I think
that based on how it's used, making up a bootcmd when localcmd is
undefined is the wrong approach. It's the hook for "run what I defined
in the environment", so if not set erroring back out seems appropriate.

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to