Hi Heinrich,

On Sun, 1 Dec 2024 at 17:24, Heinrich Schuchardt <xypron.g...@gmx.de> wrote:
>
> Am 2. Dezember 2024 01:12:36 MEZ schrieb Simon Glass <s...@chromium.org>:
> >It is a bit of a pain to log EFI boot-services calls at present. The
> >output goes to the console so cannot easily be inspected later. Also it
> >would be useful to be able to store the log and review it later, perhaps
> >after something has gone wrong.
> >
> >This series makes a start on implementing a log-to-buffer feature. It
> >provides a simple 'efidebug log' command to inspect the buffer. For now,
> >only memory allocations are logged.
>
> In my previous review I suggested to move your work to the level of the 
> logging library lib/log.c.

Well, we could do that, if we actually have a need for programmatic
logging of other subsystems.

>
> Why are you reiterating your series without exposing why an EFI specific 
> solution. should be desireable?

I don't see that need yet, or at least, not for the purpose I am
heading towards. In any case, we can easily refactor the code later if
it is needed. For now I believe that this logging feature will help to
tame some of the troubles we have.

[..]

Regards,
Simon

Reply via email to