On Friday, May 13, 2011 16:52:00 Simon Glass wrote: > --- /dev/null > +++ b/common/bootstage.c > +/* > + * Copyright (c) 2011 The Chromium OS Authors.
i'm not sure this is valid unless "Chromium OS Authors" is a legal entity
> +uint32_t bootstage_mark(enum bootstage_id id, const char *name)
> +{
> + struct bootstage_record *rec = &record[id];
> +
> + /* Only record the first event for each */
> + if (!rec->name) {
> + rec->time_us = (uint32_t)timer_get_us();
cast is pointless when time_us is of uint32_t type
> --- /dev/null
> +++ b/include/bootstage.h
> +enum bootstage_id {
> + BOOTSTAGE_AWAKE,
> + BOOTSTAGE_START_UBOOT,
> + BOOTSTAGE_USB_START,
> + BOOTSTAGE_ETH_START,
> + BOOTSTAGE_BOOTP_START,
> + BOOTSTAGE_BOOTP_STOP,
> + BOOTSTAGE_KERNELREAD_START,
> + BOOTSTAGE_KERNELREAD_STOP,
> + BOOTSTAGE_BOOTM_START,
> + BOOTSTAGE_BOOTM_HANDOFF,
> +
> + /* a few spare for the user, from here */
> + BOOTSTAGE_USER,
> +
> + /*
> + * Total number of entries - increase this at the cost of some BSS
> + * and ATAG space.
> + */
> + BOOTSTAGE_COUNT = 10
> +};
mmm BOOTSTAGE_COUNT supposed to be the number of enum's ? hardcoding the
number doesnt seem like a good idea ... how about just placing it at the right
location in the list and let gcc calc the right value ?
> +static inline uint32_t bootstage_mark(enum bootstage_id id, const char
> *name) {}
missing a return value
> --- a/include/common.h
> +++ b/include/common.h
> +#include <bootstage.h>
in general, i'd rather see individual files opt in to the headers they need
rather than having one giant header that includes everything else ...
-mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
