Hi Stefano,
On Fri, May 13, 2011 at 6:01 AM, Stefano Babic <sba...@denx.de> wrote:
...
>> +#
>> +# (C Copyright 2009
>
> Can you add the missing ")" ? I know it was my mistake, but we are
> spreading this on more files ;-)
Sure. Will send it in v2.
...
>> +int board_mmc_init(bd_t *bis)
>> +{
>> + u32 index;
>> + s32 status = 0;
>> +
>> + for (index = 0; index < CONFIG_SYS_FSL_ESDHC_NUM; index++) {
>
> You have a loop, but you set CONFIG_SYS_FSL_ESDHC_NUM to 1. How many SD
> slots has this board ? If you have only one, do we need the loop ? I
> know, this is a personal taste, I am not against if you think the code
> is clear enough. As I do not know your board, I want mainly know if this
> board supports more as one slot, maybe in future.
Yes, it has a standard SD connector on esdhc1 and also a iNAND on
esdhc3 . On this patch I only enable esdhc1, but I plan to add support
to the iNAND in the future.
>
>> +int board_late_init(void)
>> +{
>> + return 0;
>> +}
>
> If you do not need this function, simply drop BOARD_LATE_INIT from the
> config file and remove this function.
OK, good point.
Regards,
Fabio Estevam
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
