On Wed, Nov 13, 2024 at 07:42:57AM -0700, Simon Glass wrote: > Hi Tom, > > On Wed, 13 Nov 2024 at 07:12, Tom Rini <tr...@konsulko.com> wrote: > > > > On Wed, Nov 13, 2024 at 06:39:43AM -0700, Simon Glass wrote: > > > Hi Heinrich, > > > > > > On Sun, 3 Nov 2024 at 15:42, Heinrich Schuchardt > > > <heinrich.schucha...@canonical.com> wrote: > > > > > > > > We often convert hexadecimal strings to hextoull(). Provide a wrapper > > > > function to simple_strtoull() that does not require specifying the > > > > radix. > > > > > > > > Signed-off-by: Heinrich Schuchardt <heinrich.schucha...@canonical.com> > > > > --- > > > > v2: > > > > no change > > > > --- > > > > include/vsprintf.h | 13 +++++++++++++ > > > > lib/strto.c | 5 +++++ > > > > 2 files changed, 18 insertions(+) > > > > > > Could you add a test? > > > > We have tests already for this. But they weren't being run, which is > > covered by 4/4. > > I'm not seeing a test for hextoull(). Where are you looking? > > There is a test for hextoul() in test/str_ut.c
Oh sorry, I was referring to the overall problem this series addresses. -- Tom
signature.asc
Description: PGP signature