On Mon, Nov 04, 2024 at 09:58:50PM +0100, Heinrich Schuchardt wrote:
> 
> 
> Am 4. November 2024 14:39:48 MEZ schrieb Simon Glass <s...@chromium.org>:
> >The package names are slightly different for arm64 and we don't seem to
> >have a linux-image-kvm package. Provide a different set for arm64
> >
> >Signed-off-by: Simon Glass <s...@chromium.org>
> >---
> >
> > tools/docker/Dockerfile | 12 +++++++-----
> > 1 file changed, 7 insertions(+), 5 deletions(-)
> >
> >diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile
> >index c9d794082c8..c4c3dc5a901 100644
> >--- a/tools/docker/Dockerfile
> >+++ b/tools/docker/Dockerfile
> >@@ -39,7 +39,12 @@ RUN wget -O - 
> >https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_
> > RUN wget -O - 
> > https://github.com/foss-xtensa/toolchain/releases/download/2020.07/x86_64-2020.07-xtensa-dc233c-elf.tar.gz
> >  | tar -C /opt -xz
> > 
> > # Update and install things from apt now
> >-RUN apt-get update && apt-get install -y \
> >+RUN if [ "$TARGETPLATFORM" = "linux/arm64" ]; then \
> 
> Please, use 'arm64' and not 'linux/arm64' as variable value.

Getting back to your previous comment about documenting these variables,
I took it that these are NOT free-form but rather what Docker (et al)
require for proper multi-architecture containering.

-- 
Tom

Attachment: signature.asc
Description: PGP signature

Reply via email to