Hi Tom, On Thu, 31 Oct 2024 at 19:42, Tom Rini <tr...@konsulko.com> wrote: > > On Thu, Oct 31, 2024 at 07:00:24PM +0100, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 30 Oct 2024 at 00:53, Tom Rini <tr...@konsulko.com> wrote: > > > > > > On Wed, Oct 09, 2024 at 07:51:37PM -0600, Simon Glass wrote: > > > > > > > Sometimes we know that the board is already running the right software, > > > > so provide an option to allow running of tests directly, without first > > > > resetting the board. > > > > > > > > This saves time when re-running a test where only the Python code is > > > > changing. > > > > > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > > > > > I'm not NAK'ing this, but this is not a open to errors kind of change > > > that I like. It also feels like an unrelated "I find this change useful" > > > kind of change. > > > > Are you saying this change is open to errors? > > > > It just avoids needing to reset the board when I know it is already in > > a good state. So it is a time-saver. > > Yes, I'm saying it's open to errors since your assumption is "the board > is running what I want to test". As a human, I've violated that > assumption in the past running tests and short-circuiting the loop to > just re-test what's running.
Yes, that's why it is an option. I sometimes find myself iterating on the pytest part of a test, where U-Boot is not changing. Regards, Simon
