Hi Jan, On Tue, 22 Oct 2024 at 21:41, Jan Kiszka <jan.kis...@siemens.com> wrote: > > On 22.10.24 19:00, Simon Glass wrote: > > On Tue, 22 Oct 2024 at 08:06, Jan Kiszka <jan.kis...@siemens.com> wrote: > >> > >> From: Jan Kiszka <jan.kis...@siemens.com> > >> > >> Allow for the sysinfo drivers to provide a system UUID to SMBIOS. Will > >> be first used by the IOT2050 boards. > >> > >> Based on original patch by Li Hua Qian. > >> > >> Signed-off-by: Jan Kiszka <jan.kis...@siemens.com> > >> --- > >> include/sysinfo.h | 1 + > >> lib/smbios.c | 4 ++++ > >> 2 files changed, 5 insertions(+) > > > > Reviewed-by: Simon Glass <s...@chromium.org> > > > > What is this used for? Would you mind adding a comment for it? Should > > mention that it is a struct uuid > > > > What exactly is unclear here? The System UUID is a part of the SMBIOS > spec that U-Boot just ignored so far.
OK, well that just mention that, along with the data type. Regards, Simon
