On Tue, Oct 22, 2024 at 07:00:46PM +0200, Simon Glass wrote: > Hi Tom, > > On Tue, 22 Oct 2024 at 16:02, Tom Rini <tr...@konsulko.com> wrote: > > > > On Tue, Oct 22, 2024 at 02:15:34PM +0200, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 21 Oct 2024 at 19:26, Tom Rini <tr...@konsulko.com> wrote: > > > > > > > > On Mon, Oct 21, 2024 at 01:38:08PM +0200, Simon Glass wrote: > > > > > There has been an LED framework in U-Boot which uses driver model for > > > > > about 9 years now. Recent work is underway to improve it and provide > > > > > more features. It is probably a good time to drop the old code, which > > > > > is only used by 5 boards: > > > > > > > > > > ./tools/qconfig.py -f LED_STATUS > > > > > 5 matches > > > > > eb_cpu5282 eb_cpu5282_internal mx23_olinuxino pinephone > > > > > socfpga_vining_fpga > > > > > > > > > > This series attempts that. > > > > > > > > > > Changes in v2: > > > > > - Combine code-removal and defconfig changes > > > > > - Add a patch to enable LED and LED_BOOT for these boards > > > > > - Add a patch to enable LED and LED_BOOT for these boards > > > > > - Enable LED on the 5 affected platforms > > > > > - Reorder patches for bisectability > > > > > > > > So I believe this means you missed the feedback of just doing the blind > > > > migration rather than disabling the feature, like we used to often do > > > > for cases where it's just a matter of changing CONFIG options. It > > > > should: > > > > - Not introduce a failure to build > > > > - Just work on platforms with either OF_UPSTREAM or semi-recent device > > > > trees > > > > - Just start working on those platforms when they do move to > > > > OF_UPSTREAM. > > > > > > Perhaps I didn't understand what you were saying. I thought you meant > > > to enable LED and LED_BOOT on these 5 boards? > > > > Ah, OK, I see the disconnects now, sorry. The first comment I saw was > > Marek's on patch #2. So yes, along with Peter's request instead of one > > commit to disable and another commit to enable, just do 5 commits to > > migrate from one to the other please, thanks. > > In order to maintain bisectability I need to delete some code in each > of those commits. But if that is OK, then yes, I believe this is > possible.
Yes, thanks. -- Tom
signature.asc
Description: PGP signature
