On Tue, Oct 08, 2024 at 07:55:26PM -0600, Simon Glass wrote: > > WARNING: This email originated from outside of GE HealthCare. Please validate > the sender's email address before clicking on links or attachments as they > may not be safe. > > Hi Brian, > > On Mon, 7 Oct 2024 at 07:02, Brian Ruley <brian.ru...@gehealthcare.com> wrote: > > > > Add coverage for IMX8M code siging. Create PKI tree and other assets > > required by `cst' using `hab4_pki_tree.sh' script in `cst_3.4.1' [1]. > > > > [1] > > https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.nxp.com%2Fwebapp%2FDownload%3FcolCode%3DIMX_CST_TOOL_NEW&data=05%7C02%7Cbrian.ruley%40gehealthcare.com%7C6c5f10f7a5924f834a9108dce8057a0f%7C9a309606d6ec4188a28a298812b4bbbf%7C0%7C0%7C638640357480346828%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=%2FFjvh%2BAUwpiUxyePSbhmW386iDV65%2BbJHwUiTWwOgok%3D&reserved=0 > > > > Signed-off-by: Brian Ruley <brian.ru...@gehealthcare.com> > > --- > > Please can you check the indentation? > Fixed it.
> I don't see the .pem files in your patch? > Argh! Sorry about that, I didn't realize that .pem files were ignored by git :) > Also we should really tidy up the etype so that it can read keys from > the input path, or perhaps use an entryarg to point to the file. > Having paths in the image description is not ideal. > I sent a new patch preceeding this one, but I've rebased everything on top of [PATCH v4 2/2] binman: add fast authentication method for i.MX8M signing, I hope that's fine? The etype will now look for the certificates and keys relative to the input directory. I've also added the ability to specify an extra input directory to search first. Best, Brian
