Hi Dmitry, On Wed, 9 Oct 2024 at 07:26, Dmitry Rokosov <ddroko...@salutedevices.com> wrote: > > Hello Simon, > > On Tue, Oct 08, 2024 at 07:57:15PM -0600, Simon Glass wrote: > > On Tue, 8 Oct 2024 at 14:18, Dmitry Rokosov <ddroko...@salutedevices.com> > > wrote: > > > > > > It's really helpful to have the ability to dump BCB block for debugging > > > A/B logic on the board supported this partition schema. > > > > > > Command 'bcb ab_dump' prints all fields of bootloader_control struct > > > including slot_metadata for all presented slots. > > > > > > Output example: > > > ===== > > > > board# bcb ab_dump ubi 0#misc > > > > Read 512 bytes from volume misc to 000000000bf07580 > > > > Read 512 bytes from volume misc to 000000000bf42f40 > > > > Bootloader Control: [misc] > > > > Active Slot: _a > > > > Magic Number: 0x42414342 > > > > Version: 1 > > > > Number of Slots: 2 > > > > Recovery Tries Remaining: 0 > > > > CRC: 0x2c8b50bc (Valid) > > > > > > > > Slot[0] Metadata: > > > > - Priority: 15 > > > > - Tries Remaining: 0 > > > > - Successful Boot: 1 > > > > - Verity Corrupted: 0 > > > > > > > > Slot[1] Metadata: > > > > - Priority: 14 > > > > - Tries Remaining: 7 > > > > - Successful Boot: 0 > > > > - Verity Corrupted: 0 > > > ==== > > > > > > Signed-off-by: Dmitry Rokosov <ddroko...@salutedevices.com> > > > --- > > > boot/android_ab.c | 68 > > > ++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > cmd/bcb.c | 35 +++++++++++++++++++++++++++ > > > include/android_ab.h | 10 ++++++++ > > > 3 files changed, 113 insertions(+) > > > > > > > Reviewed-by: Simon Glass <s...@chromium.org> > > > > Can you also update the test? > > I apologize, but I didn't quite understand your point. Could you please > clarify? This patch series includes additional tests for the 'ab_dump' > subcommand. For more details, please refer to: > > https://lore.kernel.org/all/20241008-android_ab_master-v3-6-f292c45a3...@salutedevices.com/
OK, thank you. Sometimes it is easier (for reviewers) if you update the test in the same commit. Regards, Simon
