On 11:35-20241007, Manorit Chawdhry wrote: > On 11:34-20241007, Manorit Chawdhry wrote: > > Hi Nishanth, > > > > On 06:30-20241004, Nishanth Menon wrote: > > > On 11:54-20241004, Manorit Chawdhry wrote: > > > > Add AVS and PMIC regulator configs > > > > > > > > Signed-off-by: Manorit Chawdhry <m-chawd...@ti.com> > > > > --- > > > > configs/am68_sk_r5_defconfig | 4 ++++ > > > > configs/j721s2_evm_r5_defconfig | 6 ++++++ > > > > 2 files changed, 10 insertions(+) > > > > > > > > diff --git a/configs/am68_sk_r5_defconfig b/configs/am68_sk_r5_defconfig > > > > index e9b6882c1f68..f4800ef1b8ac 100644 > > > > --- a/configs/am68_sk_r5_defconfig > > > > +++ b/configs/am68_sk_r5_defconfig > > > > @@ -5,6 +5,10 @@ CONFIG_ARCH_K3=y > > > > CONFIG_SOC_K3_J721S2=y > > > > CONFIG_TARGET_J721S2_R5_EVM=y > > > > > > > > +CONFIG_K3_AVS0=n > > > > +CONFIG_DM_REGULATOR_TPS65941=n > > > > +CONFIG_PMIC_TPS65941=n > > > > + > > > > CONFIG_DEFAULT_DEVICE_TREE="k3-am68-sk-r5-base-board" > > > > CONFIG_SPL_OF_LIST="k3-am68-sk-r5-base-board" > > > > CONFIG_OF_LIST="k3-am68-sk-r5-base-board" > > > > diff --git a/configs/j721s2_evm_r5_defconfig > > > > b/configs/j721s2_evm_r5_defconfig > > > > index b6adb6a77d7e..ad7653c8f99b 100644 > > > > --- a/configs/j721s2_evm_r5_defconfig > > > > +++ b/configs/j721s2_evm_r5_defconfig > > > > @@ -112,6 +112,7 @@ CONFIG_DM_MAILBOX=y > > > > CONFIG_K3_SEC_PROXY=y > > > > CONFIG_FS_LOADER=y > > > > CONFIG_SPL_FS_LOADER=y > > > > +CONFIG_K3_AVS0=y > > > > CONFIG_SUPPORT_EMMC_BOOT=y > > > > CONFIG_SPL_MMC_HS400_SUPPORT=y > > > > CONFIG_MMC_SDHCI=y > > > > @@ -141,6 +142,11 @@ CONFIG_SPL_PINCTRL=y > > > > CONFIG_PINCTRL_SINGLE=y > > > > CONFIG_POWER_DOMAIN=y > > > > CONFIG_TI_POWER_DOMAIN=y > > > > +CONFIG_DM_PMIC=y > > > > +CONFIG_PMIC_TPS65941=y > > > > +CONFIG_DM_REGULATOR=y > > > > +CONFIG_SPL_DM_REGULATOR=y > > > > +CONFIG_DM_REGULATOR_TPS65941=y > > > > CONFIG_K3_SYSTEM_CONTROLLER=y > > > > CONFIG_REMOTEPROC_TI_K3_ARM64=y > > > > CONFIG_RESET_TI_SCI=y > > > > > > > > > Why are we mixing two different boards? > > > > > > > AM68 includes J721s2 defconfig for re-usability so if some board related > > feature is being enabled on J721s2, that needs to be taken care that it > > doesn't get enabled on AM68 if it doesn't support. > > Board related in the sense that AVS requires PMIC support but that isn't > available yet so can't add the support for the same.
The commit message definitely needs to be updated to the effect. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
