On Thu, Aug 29, 2024 at 07:04:36PM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 29 Aug 2024 at 10:59, Tom Rini <tr...@konsulko.com> wrote: > > > > On Thu, Aug 29, 2024 at 09:01:17AM -0600, Simon Glass wrote: > > > Hi Neil, > > > > > > On Thu, 29 Aug 2024 at 08:26, <neil.armstr...@linaro.org> wrote: > > > > > > > > On 29/08/2024 00:08, Simon Glass wrote: > > > > > Send the Labgrid quit characters to ask it to exit gracefully. This > > > > > typically allows it to power off the board being used. > > > > > > > > Sending those characters every time could collide with other CI systems, > > > > I don't think it's a good idea. > > > > > > What systems are you thinking about and what sort of collision would > > > occur? > > > > > > What do you suggest instead? > > > > Why do we need this at all? Did I miss where we send picocom the > > disconnect nicely key-combination? > > When labgrid gets a signal, it exits. It doesn't continue its > co-routines and execute the end strategy to power things off, etc. I > suspect it could be made to do that, but I already have 62 Labgrid > patches, so I thought this would be expedient... > > I can make this conditional on the new USE_LABGRID variable.
It sounds to me like we need to make generic improvements to our hooks then, if there's not a "now call poweroff" hook. -- Tom
signature.asc
Description: PGP signature
