On Wed, 14 Aug 2024 at 07:22, Chintan Vankar <c-van...@ti.com> wrote:
>
>
>
> On 13/08/24 18:17, Nishanth Menon wrote:
> > On 16:24-20240813, Chintan Vankar wrote:
> >> Add missing bootph-all property for CPSW MAC's PHY node
> >> phy_gmii_sel.
> >>
> >> Signed-off-by: Chintan Vankar <c-van...@ti.com>
> >> Link: https://lore.kernel.org/r/20240430085048.3143665-1-c-van...@ti.com
> >> Signed-off-by: Vignesh Raghavendra <vigne...@ti.com>
> >>
> >> [ upstream commit: ba50141137fae205a731005e70687f4a52289050 ]
> >>
> >> (cherry picked from commit 2bdd1743a9f6515efe7c3648a25d63b4a9ce4a10)
> >> ---
> >>
> >> Link to v4:
> >> https://lore.kernel.org/r/20240812114945.3844224-1-c-van...@ti.com/
> >>
> >> Changes from v4 to v5:
> >> - Updated this patch with the cherry picked patch from
> >> devicetree-rebasing repo as pointed out by Sumit.
> >>
> >> dts/upstream/src/arm64/ti/k3-am62x-sk-common.dtsi | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
Reviewed-by: Sumit Garg <sumit.g...@linaro.org>
> >> diff --git a/dts/upstream/src/arm64/ti/k3-am62x-sk-common.dtsi
> >> b/dts/upstream/src/arm64/ti/k3-am62x-sk-common.dtsi
> >> index 3c45782ab2b..96378b19c41 100644
> >> --- a/dts/upstream/src/arm64/ti/k3-am62x-sk-common.dtsi
> >> +++ b/dts/upstream/src/arm64/ti/k3-am62x-sk-common.dtsi
> >> @@ -128,6 +128,10 @@
> >> };
> >> };
> >>
> >> +&phy_gmii_sel {
> >> + bootph-all;
> >> +};
> >> +
> >
> >
> > If you cannot wait for upstream dt sync, why not just do this in R5-sk
> > or u-boot.dtsi?
> >
> >
>
> This node was added in "k3-am625-sk-u-boot.dtsi" till v3 of this series,
> https://lore.kernel.org/all/20240705045030.1141934-11-c-van...@ti.com/
> but Tom suggested to use cherry pick since equivalent node got merged in
> Linux:
> https://lore.kernel.org/r/171826022268.240984.16645643062603851712.b4...@ti.com/
Yeah cherry-picking is better than adding bits into u-boot.dtsi as the
next DT sync can manage bits automatically without the need to drop
bits from u-boot.dtsi again.
-Sumit
