Hi Heinrich, On Wed, 7 Aug 2024 at 14:52, Simon Glass <s...@chromium.org> wrote: > > Hi Heinrich, > > On Wed, 7 Aug 2024 at 08:39, Heinrich Schuchardt > <heinrich.schucha...@canonical.com> wrote: > > > > On 07.08.24 16:36, Simon Glass wrote: > > > On Tue, 6 Aug 2024 at 18:13, Heinrich Schuchardt > > > <heinrich.schucha...@canonical.com> wrote: > > >> > > >> For SATA devices the class name is 'ahci' but the block device name is > > >> 'sata'. > > >> > > >> Use function blk_get_uclass_name() to retrieve the correct string. > > >> > > >> Signed-off-by: Heinrich Schuchardt <heinrich.schucha...@canonical.com> > > >> --- > > >> boot/bootmeth_efi.c | 7 +++---- > > >> 1 file changed, 3 insertions(+), 4 deletions(-) > > >> > > > > > > Reviewed-by: Simon Glass <s...@chromium.org> > > > > > > Hmm I suppose I need to do another round to try to get rid of > > > blk_desc->uclass_id > > > > efi_set_bootdev() should take a udevice in future. > > > > We are converting to string and later back to device before we create a > > device-path. This makes little sense. > > Yes indeed. I've added it to my list.
But sadly, we still have code for ~DM_BLK so that has to happen first, so I've taken it off my list. I tried to send a series to remove old I2C stuff, but it is still pending. Regards, Simon
