Hi Ilias, On Fri, 26 Jul 2024 at 06:10, Ilias Apalodimas <ilias.apalodi...@linaro.org> wrote:
> Hi Raymond > > On Tue, 2 Jul 2024 at 21:33, Raymond Mao <raymond....@linaro.org> wrote: > > > > Add porting layer for MSCode on top of MbedTLS ASN1 library. > > Introduce _LEGACY and _MBEDTLS kconfigs for MSCode legacy and > > MbedTLS implementations respectively. > > You should mention explicitly on the commit message, that this patch > is expected to be merged in mbedTLS upstream and we can remove it in > the future > > This patch is native U-Boot patch. The ones for MbedTLS upstream are all tagged with "mbedtls/external". > > > > > Signed-off-by: Raymond Mao <raymond....@linaro.org> > > --- > > Changes in v2 > > - Move the porting layer to MbedTLS dir. > > Changes in v3 > > - None. > > Changes in v4 > > - Introduce _LEGACY and _MBEDTLS kconfigs for MSCode legacy and > > MbedTLS implementations respectively. > > - Fix a few code style. > > > > lib/mbedtls/Kconfig | 17 +++++ > > lib/mbedtls/Makefile | 1 + > > lib/mbedtls/mscode_parser.c | 123 ++++++++++++++++++++++++++++++++++++ > > 3 files changed, 141 insertions(+) > > create mode 100644 lib/mbedtls/mscode_parser.c > > > > diff --git a/lib/mbedtls/Kconfig b/lib/mbedtls/Kconfig > > index 8c5b617bb48..d8a8f87e031 100644 > > --- a/lib/mbedtls/Kconfig > > +++ b/lib/mbedtls/Kconfig > > @@ -126,6 +126,7 @@ config LEGACY_CRYPTO_CERT > > ASYMMETRIC_PUBLIC_KEY_SUBTYPE > > select X509_CERTIFICATE_PARSER_LEGACY if X509_CERTIFICATE_PARSER > > select PKCS7_MESSAGE_PARSER_LEGACY if PKCS7_MESSAGE_PARSER > > + select MSCODE_PARSER_LEGACY if MSCODE_PARSER > > select SPL_ASYMMETRIC_PUBLIC_KEY_SUBTYPE_LEGACY if \ > > ASYMMETRIC_PUBLIC_KEY_SUBTYPE && SPL > > help > > @@ -156,6 +157,14 @@ config PKCS7_MESSAGE_PARSER_LEGACY > > This option chooses legacy certificate library for PKCS7 > message > > parser. > > > > +config MSCODE_PARSER_LEGACY > > Where is this used? Is it on a later patch? The MSCODE_PARSER_MBEDTLS > option is part of this patch on the Makefile > > It is used in the next patch (#24) , it is good to split into two since they are in different domains (mbedtls/crypto). Regards, Raymond
