Hi, On 19/07/24 1:17 am, Michael Nazzareno Trimarchi wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Hi > > On Thu, Jul 18, 2024 at 9:40 PM Zixun Li <z...@ogga.fr> wrote: >> >> On 10/07/2024 09:28, Alexander Dahl wrote: >> >>> Despite the missing space between 'if' and the opening bracket (checkpatch >>> should have told you?) this looks very much like what got into linux with >>> v4.11 >>> but was changed/reworked multiple times afterwards. I wonder why this was >>> not ported to U-Boot when introducing this driver? In 6a8dfd57220d ("nand: >>> atmel: Add DM based NAND driver") it was claimed the driver was ported >>> from linux-5.4-at91, so this feature was probably dropped intentionally? >>> Does anyone know why? >>> >> >> Hi, >> >> Sorry for the format issue. Is there any comment from maintainers ? >> >> I'll push a v2 if this patch is considered. > > Looking on it. Anyway expand the commit message with original information of > it. > Like: > > Upstream commit <short sha> > > Try to report some original context from kernel > > Micahel >
Sorry for the delay in response. This change was accidentally missed during porting. And was not dropped intentionally. Thanks for the patch. Bala. > >> -- >> Zixun LI >> >> > > > -- > Michael Nazzareno Trimarchi > Co-Founder & Chief Executive Officer > M. +39 347 913 2170 > mich...@amarulasolutions.com > __________________________________ > > Amarula Solutions BV > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL > T. +31 (0)85 111 9172 > i...@amarulasolutions.com > www.amarulasolutions.com