Hi, On Sunday, 1 October 2023 21:17:21 CEST Jonas Karlman wrote: > Enable DWC_ETH_QOS_ROCKCHIP and related PHY driver on RK356x boards that > have an enabled gmac node. > > Signed-off-by: Jonas Karlman <jo...@kwiboo.se> > Reviewed-by: Kever Yang <kever.y...@rock-chips.com> > --- > ... > configs/odroid-m1-rk3568_defconfig | 3 +++ > configs/quartz64-a-rk3566_defconfig | 3 +++ > configs/quartz64-b-rk3566_defconfig | 3 +++ > ... > configs/soquartz-blade-rk3566_defconfig | 3 +++ > configs/soquartz-cm4-rk3566_defconfig | 3 +++ > configs/soquartz-model-a-rk3566_defconfig | 3 +++ > 11 files changed, 35 insertions(+), 6 deletions(-) > ... > diff --git a/configs/odroid-m1-rk3568_defconfig > b/configs/odroid-m1-rk3568_defconfig index 3dda5c1f9170..96b4e9ecdaff > 100644 > --- a/configs/odroid-m1-rk3568_defconfig > +++ b/configs/odroid-m1-rk3568_defconfig > @@ -82,6 +82,9 @@ CONFIG_SF_DEFAULT_BUS=4 > CONFIG_SPI_FLASH_SFDP_SUPPORT=y > CONFIG_SPI_FLASH_MACRONIX=y > CONFIG_SPI_FLASH_MTD=y > +CONFIG_PHY_REALTEK=y > +CONFIG_DWC_ETH_QOS=y > +CONFIG_DWC_ETH_QOS_ROCKCHIP=y > CONFIG_NVME_PCI=y > CONFIG_PCIE_DW_ROCKCHIP=y > CONFIG_PHY_ROCKCHIP_INNO_USB2=y > diff --git a/configs/quartz64-a-rk3566_defconfig > b/configs/quartz64-a-rk3566_defconfig index 6853cd6c44b4..bf4d4cd2b8ed > 100644 > --- a/configs/quartz64-a-rk3566_defconfig > +++ b/configs/quartz64-a-rk3566_defconfig > @@ -81,6 +81,9 @@ CONFIG_SPI_FLASH_SFDP_SUPPORT=y > CONFIG_SPI_FLASH_GIGADEVICE=y > CONFIG_SPI_FLASH_MACRONIX=y > CONFIG_SPI_FLASH_WINBOND=y > +CONFIG_PHY_MOTORCOMM=y > +CONFIG_DWC_ETH_QOS=y > +CONFIG_DWC_ETH_QOS_ROCKCHIP=y > CONFIG_NVME_PCI=y > CONFIG_PCIE_DW_ROCKCHIP=y > CONFIG_PHY_ROCKCHIP_INNO_USB2=y > diff --git a/configs/quartz64-b-rk3566_defconfig > b/configs/quartz64-b-rk3566_defconfig index aa29fff14643..358687ab5d7f > 100644 > --- a/configs/quartz64-b-rk3566_defconfig > +++ b/configs/quartz64-b-rk3566_defconfig > @@ -79,6 +79,9 @@ CONFIG_SPI_FLASH_SFDP_SUPPORT=y > CONFIG_SPI_FLASH_GIGADEVICE=y > CONFIG_SPI_FLASH_MACRONIX=y > CONFIG_SPI_FLASH_WINBOND=y > +CONFIG_PHY_REALTEK=y > +CONFIG_DWC_ETH_QOS=y > +CONFIG_DWC_ETH_QOS_ROCKCHIP=y > CONFIG_NVME_PCI=y > CONFIG_PCIE_DW_ROCKCHIP=y > CONFIG_PHY_ROCKCHIP_INNO_USB2=y
Some time ago I reported to Jonas privately that I had a problem with my Quartz64 Model A and B and that I bisected it to this commit. I just verified that the problem is still present in 2024.07, so I guess it's time to report it to the (right) Mailing List. The problem: packet loss, varying, but sometimes massive Q64-A: The packet loss was usually between 8% and 30% Q64-B: Packet loss up to 80% sometimes and this also resulted (then) in its inability to receive a DHCP address. https://lore.kernel.org/linux-rockchip/27139798.WhXITi6ROJ@bagend/ is where I brought this issue (also) up publicly, but that was on the linux-rockchip ML. The discussion that followed may provide some clues. When looking up the mail I'm now replying too, I noticed a reply by Stefan Agner with very similar symptoms, but on Odroid M1. And the fix in my case has always been easy: diff --git a/configs/quartz64-a-rk3566_defconfig b/configs/quartz64-a-rk3566_defconfig index 1ea8e0f40cc..641452f9162 100644 --- a/configs/quartz64-a-rk3566_defconfig +++ b/configs/quartz64-a-rk3566_defconfig @@ -67,9 +67,6 @@ CONFIG_SPI_FLASH_SFDP_SUPPORT=y CONFIG_SPI_FLASH_GIGADEVICE=y CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_WINBOND=y -CONFIG_PHY_MOTORCOMM=y -CONFIG_DWC_ETH_QOS=y -CONFIG_DWC_ETH_QOS_ROCKCHIP=y CONFIG_NVME_PCI=y CONFIG_PCIE_DW_ROCKCHIP=y CONFIG_PHY_ROCKCHIP_INNO_USB2=y diff --git a/configs/quartz64-b-rk3566_defconfig b/configs/quartz64-b-rk3566_defconfig index f61b2c181a1..aae5d66edeb 100644 --- a/configs/quartz64-b-rk3566_defconfig +++ b/configs/quartz64-b-rk3566_defconfig @@ -65,9 +65,6 @@ CONFIG_SPI_FLASH_SFDP_SUPPORT=y CONFIG_SPI_FLASH_GIGADEVICE=y CONFIG_SPI_FLASH_MACRONIX=y CONFIG_SPI_FLASH_WINBOND=y -CONFIG_PHY_REALTEK=y -CONFIG_DWC_ETH_QOS=y -CONFIG_DWC_ETH_QOS_ROCKCHIP=y CONFIG_NVME_PCI=y CONFIG_PCIE_DW_ROCKCHIP=y CONFIG_PHY_ROCKCHIP_INNO_USB2=y IOW: a (partial) revert of commit 25f56459aebc It _could_ be that the issue is also present on the various SOQuartz devices/boards, but I don't have those, so I can't check that. But AFAIK they are rather similar to Q64-A and the change has also been the same ... as was the case for Odroid-M1. In case it's useful I have a log from the serial session with the Q64-A (212.5 KiB) available. Serial on Q64-B doesn't work, so I don't have that. Cheers, Diederik
signature.asc
Description: This is a digitally signed message part.
