Hi, Stefano,
2011/4/20 Stefano Babic <sba...@denx.de>:
> On 04/18/2011 11:19 AM, Detlev Zundel wrote:
>> Hi Stefano,
>>
>>> On 04/15/2011 02:47 PM, Fabio Estevam wrote:
>>>>> +char *get_reset_cause(void)
>>>>> +{
>>>>> + u32 cause;
>>>>> + struct src *src_regs = (struct src
>>>>> *)SRC_BASE_ADDR;
>>>>> +
>>>>> + cause = readl(&src_regs->srsr);
>>>>
>>>> You need to mask the 7 LSB of SRSR register.
>>>>
>>>> If you don´t bit 16 can still affect its result.
>>>
>>> Why ? As this becomes a general function for i.MX5, should we not
>>> provide a way to check all significant bits ? Why should we exclude the
>>> "warm boot" bit to be checked and printed out ?
>>
>> And _please_ (as indictated in my i.MX31 mail) use the code for _all_
>> iMX51 boards withoput the need for them to call a function and print the
>> result.
>
> Jason,
>
> I noted only now that this comment was not directly addressed to you,
> but it is related to your patch. As you see for the i.MX31, the result
> of the discussion was to call the get_reset_cause() inside the
> print_cpuinfo() function, to make automatically this function available
> for all MX5 boards.
Yes, I have send out the v5 patch for it. please review it. Thanks,
Jason
>
> Regards,
> Stefano
>
> --
> =====================================================================
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: off...@denx.de
> =====================================================================
>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
