Wolfgang Denk <w...@denx.de> wrote on 2011/04/20 00:05:27:
> From: Wolfgang Denk <w...@denx.de> > To: Joakim Tjernlund <joakim.tjernl...@transmode.se> > Cc: u-boot@lists.denx.de > Date: 2011/04/20 00:05 > Subject: Re: [U-Boot] [PATCH] PowerPC: Move -fPIC flag to common place > > Dear Joakim Tjernlund, > > In message > <ofc5a52df3.355573b0-onc1257877.0078430f-c1257877.00789...@transmode.se> you > wrote: > > > > > That means I will revert the two commits? > > > > One, you only claimed that: > > > The -fPIC flag belongs with -mrelocatable, move it there. > > > Also change -fPIC to -fpic as this produces smaller > > > binaries. > > > However, currently -mrelocatable promotes -fpic to -fPIC, a > > > fix for this is in upcoming gcc 4.6 or you can apply this small > > > patch to gcc: > > Broke all those 8xx boards. > > Yes, but you yorself pointed out that commit 337f5f5 missed a large > number of boards, leaving the tree in a inconsistent state. Should we > not revert that one as well? It is not too bad, just not complete yet. Reverting all just makes it harder to get it all done. I still don't get why it broke really. hmm, did you by any chance include my patches to gcc too? if so I you should only have to fixup arch/powerpc/config.mk: - PLATFORM_RELFLAGS += -fpic -mrelocatable -ffunction-sections -fdata-sections - PLATFORM_RELFLAGS += $(call cc-option,-msingle-pic-base,) + PLATFORM_RELFLAGS += -fPIC -mrelocatable -ffunction-sections -fdata-sections _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
