Hi Dragan,
On 6/17/24 7:57 PM, Dragan Simic wrote:
On 2024-06-17 18:48, Quentin Schulz wrote:
From: Quentin Schulz <quentin.sch...@cherry.de>
Commit 2ce40542e0eb ("power: rk8xx: properly print all supported PMICs
name") fixed all PMICs name that were broken but broke the only one that
was not broken already: RK808. This one is a special case because the ID
registers are marked as reserved and always return 0, so the variant
cannot be derived the same way it is done for other PMICs from Rockchip.
Fixes: 2ce40542e0eb ("power: rk8xx: properly print all supported PMICs
name")
Signed-off-by: Quentin Schulz <quentin.sch...@cherry.de>
Looking good to me, but I'd still suggest [1] that reading the MSB/LSB ID
registers (i.e. 0x17 and 0x18) is skipped on the RK808 altogether, because
the RK808 datasheet lists those two registers as reserved and provides no
methods for determining the chip name.
Rockchip themselves do this, c.f.:
https://github.com/rockchip-linux/u-boot/blob/next-dev/drivers/power/pmic/rk8xx.c#L587
I won't send a patch for this, but feel free to send one if you feel
like this is really important.
Reviewed-by: Dragan Simic <dsi...@manjaro.org>
Thanks!
Quentin
