On Sat, 8 Jun 2024 at 06:59, Heinrich Schuchardt <xypron.g...@gmx.de> wrote:
>
>
>
> Am 7. Juni 2024 20:52:37 MESZ schrieb Sughosh Ganu <sughosh.g...@linaro.org>:
> >The LMB memory map is now persistent and global. There is therefore no
> >need to add memory to the LMB memory map as part of the bdinfo
> >command. Only dump the current available and reserved memory as part
> >of the bdinfo command.
>
> Would it make sense to move printing lmb memory to a separate command instead?
Yes. Since are permanently reserving memory regions now we should have
a command to dump them.
Perhaps re-use cmd/mem.c?
Regards
/Ilias
>
> Best regards
>
> Heinrich
>
> >
> >Signed-off-by: Sughosh Ganu <sughosh.g...@linaro.org>
> >---
> > cmd/bdinfo.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> >diff --git a/cmd/bdinfo.c b/cmd/bdinfo.c
> >index fc408e9820..0f343203ef 100644
> >--- a/cmd/bdinfo.c
> >+++ b/cmd/bdinfo.c
> >@@ -163,7 +163,6 @@ static int bdinfo_print_all(struct bd_info *bd)
> > bdinfo_print_num_l("multi_dtb_fit", (ulong)gd->multi_dtb_fit);
> > #endif
> > if (IS_ENABLED(CONFIG_LMB) && gd->fdt_blob) {
> >- lmb_add_memory(gd->bd);
> > lmb_dump_all_force();
> > if (IS_ENABLED(CONFIG_OF_REAL))
> > printf("devicetree = %s\n", fdtdec_get_srcname());
