Dear Simon Glass, In message <BANLkTinacFQ=1xa4ptgzki5on9agg7-...@mail.gmail.com> you wrote: > > >> +static void smsc95xx_halt(struct eth_device *eth) > >> +{ > >> + debug("** %s()\n", __func__); > >> +} > > > > is this right ? shouldnt you be halting something ? > > I could do, but halting is not in the driver at present. Do you think > it is important?
Yes, it is important to shut down devices. Especially with USB devices. BTW: can you *please* fix your mail addresses? It's not "Remy Bohmerl <i...@bohmer.net>" but "Remy Bohmer <li...@bohmer.net>" instead. Don't you get tons of bounce messages? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Every living thing wants to survive. -- Spock, "The Ultimate Computer", stardate 4731.3 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot