On Thu, Apr 11, 2024 at 07:37:28PM -0400, Greg Malysa wrote: > From: Nathan Barrett-Morrison <nathan.morri...@timesys.com> > > Add support for the SC5xx machine type from Analog Devices. This > includes support for the SC57x, SC58x, SC59x, and SC59x-64 SoCs, which > have many common features such as common ADI IP blocks, and SHARC DSP > cores. This commit introduces core functionality required for all boards > using an SC5xx SoC, such as: > > - SPL configuration > - Required CPU hooks such as reset > - Boot ROM interaction to load the stage 2 bootloader in the reference > configuration. Other options are possible but not officially supported > at this time > - SoC-common configuration expected to be reused by all boards > - Early initialization for system clocks and DDR controller > > Co-developed-by: Greg Malysa <greg.mal...@timesys.com> > Signed-off-by: Greg Malysa <greg.mal...@timesys.com> > Co-developed-by: Ian Roberts <ian.robe...@timesys.com> > Signed-off-by: Ian Roberts <ian.robe...@timesys.com> > Signed-off-by: Vasileios Bimpikas <vasileios.bimpi...@analog.com> > Signed-off-by: Utsav Agarwal <utsav.agar...@analog.com> > Signed-off-by: Arturs Artamonovs <arturs.artamon...@analog.com> > Signed-off-by: Nathan Barrett-Morrison <nathan.morri...@timesys.com> > > --- > > > --- > MAINTAINERS | 13 + > arch/arm/Kconfig | 6 + > arch/arm/Makefile | 1 + > arch/arm/include/asm/arch-adi/sc5xx/sc5xx.h | 115 +++ > arch/arm/include/asm/arch-adi/sc5xx/soc.h | 18 + > arch/arm/include/asm/arch-adi/sc5xx/spl.h | 41 + > arch/arm/include/asm/mach-types.h | 4 +
We shouldn't be adding more to mach-types.h. > arch/arm/mach-sc5xx/Kconfig | 464 +++++++++ Here and elsewhere I think I saw whitespace issues (help should be <TAB><space><space>) in the entries, along with adding "default n" for new options, and that's not needed as n is the default. [snip] > diff --git a/arch/arm/mach-sc5xx/config.mk b/arch/arm/mach-sc5xx/config.mk > new file mode 100644 > index 0000000000..b80644d6dc > --- /dev/null > +++ b/arch/arm/mach-sc5xx/config.mk [snip] > +ifndef CONFIG_SC59X_64 > + # Select the Analog Devices processor. > + PLATFORM_RELFLAGS += -fno-stack-protector -std=gnu89 > +endif We should be using the defaults here. Also: - Please switch to plain text environment instead of defining in board.h and so on. - Audit your #include usage, I saw more <config.h> that is likely needed for example. -- Tom
signature.asc
Description: PGP signature
