> +static void dwc3_qcom_glue_configure(struct udevice *dev, int index,
> +                                  enum usb_dr_mode mode)
> +{
> +     struct dwc3_glue_data *glue = dev_get_plat(dev);
> +     void __iomem *qscratch_base = (void __iomem *)glue->regs;
CI is not happy with this, it fails on 32-bit builds with
"cast to pointer from integer of different size
[-Werror=int-to-pointer-cast]"

Instead this should probably call map_physmem(glue->regs, 0x400,
MAP_NOCACHE);

I'll leave it a day in case there's any more feedback and then send a
new revision.
> +     if (IS_ERR_OR_NULL(qscratch_base)) {
> +             log_err("%s: Invalid qscratch base address\n", dev->name);
> +             return;
> +     }
> +
> +     if (dev_read_bool(dev, "qcom,select-utmi-as-pipe-clk"))
> +             dwc3_qcom_select_utmi_clk(qscratch_base);
> +

-- 
// Caleb (they/them)

Reply via email to